[Webfunds-devel] OpenPGP signed Contracts

Jeroen C. van Gelderen jeroen@vangelderen.org
Fri, 26 May 2000 23:19:09 -0400


Edwin Woudt wrote:
> 
> "Jeroen C. van Gelderen" wrote:
> >
> > > * webfunds/client/contracts/SignContractWizard.java
> > >   - this class should not be dealing with X509 stuff at all, so the
> > >     signature generation code will move to Contract.java
> >
> > I don't agree here. A Contract object represents a valid (hence signed)
> > contract. Subclasses of Contract should specialize based on contract
> > type (CurrencyContract, FooContract). Contract itself should be
> > immutable and able to restore itself to whatever format it came from.
> > What you need is a factory that does something along the lines of:
> >
> >  ContractInfo + PrivateKey | ContractSigner/Factory -> FooContract
> 
> Ok, but you agree it should be removed from the client code, where it
> is now, right?

Yeah! The idea was more that Contract is now more or less what I 
think it should be. So I would be in favor of keeping it as clean
as possible.

> I don't really care where it ends up, as long as I don't have to do
> all the rewriting.

Agreed.

Cheers,
Jeroen